feat(web-api): add highlight_type to files.completeUploadExternal and filesUploadV2#2594
Conversation
… filesUploadV2 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 50af6d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
==========================================
- Coverage 87.52% 87.50% -0.02%
==========================================
Files 62 62
Lines 10228 10230 +2
Branches 418 418
==========================================
Hits 8952 8952
- Misses 1254 1256 +2
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBergamin
left a comment
There was a problem hiding this comment.
Praise 🙏 thanks for working on this 💯
NOTE: I think this might be a minor rather then a patch since it introduces support for new functionality 🤔
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
@WilliamBergamin I appreciate your review so will merge this after a bit of discussion with the backend 🫡 We're now matching expected specs of the API and with |
Summary
This pull request adds
highlight_typesupport tofiles.completeUploadExternaland thefilesUploadV2method.The
highlight_typeparameter allows specifying the file type hint for uploads (e.g.png,jpg,gif), enabling optimistic rendering before the async upload processing job completes.📚 https://docs.slack.dev/reference/methods/files.completeUploadExternal/
Changes
highlight_typeto theFileUploadCompleteinterface (per-file in thefilesarray)highlight_typetoFileUploadV2so it can be specified when usingfilesUploadV2getAllFileUploadsToCompleteto passhighlight_typethrough to each file objectUsage
Requirements